port test_sharedarraybuffer to CTS#46
Open
bavulapati wants to merge 15 commits intonodejs:mainfrom
Open
Conversation
bavulapati
commented
Apr 1, 2026
| function(add_node_api_cts_experimental_addon ADDON_NAME) | ||
| cmake_parse_arguments(PARSE_ARGV 1 ARG "" "" "SOURCES") | ||
| add_node_api_cts_addon(${ADDON_NAME} ${ARG_SOURCES}) | ||
| add_node_api_cts_addon(${ADDON_NAME} ${ARGN}) |
Contributor
Author
|
@legendecas Fixed the CI issue. Can we run the tests again? |
This was referenced Apr 7, 2026
kraenhansen
reviewed
Apr 25, 2026
Comment on lines
+1
to
+5
| const napiVersion = Number(process.versions.napi); | ||
|
|
||
| const skipTest = () => { | ||
| process.exit(0); | ||
| }; |
Member
There was a problem hiding this comment.
I think we can delete this file entirely now, right?
ports [test_sharedarraybuffer] from the Node.js test suite to the CTS. Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
bavulapati
force-pushed
the
feat/port-test-sharedarraybuffer
branch
from
6b9020e to
b3b277d
Compare
Member
|
Would you mind rebasing the PR? Thanks! |
Contributor
Author
✅ |
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
legendecas
reviewed
Apr 29, 2026
| assert( | ||
| typeof import.meta.dirname === "string", | ||
| "Expecting a recent Node.js runtime API version" | ||
| "Expecting a recent Node.js runtime API version", |
Member
There was a problem hiding this comment.
Would you mind removing these unrelated changes? This would cause unnecessary merge conflicts.
Member
|
Generally LGTM, thanks! |
bavulapati
commented
Apr 29, 2026
Contributor
Author
bavulapati
left a comment
bavulapati
left a comment
There was a problem hiding this comment.
remove unrelated changes
legendecas
reviewed
Apr 30, 2026
| "node", | ||
| "gc.js" | ||
| ); | ||
| const GC_MODULE_PATH = path.join(ROOT_PATH, "implementors", "node", "gc.js"); |
Contributor
Author
There was a problem hiding this comment.
I'm using prettier. That's creating these diff.
Should we use prettier or similar?
If so, can you point me to a repo where we do similar formatting to pick the rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ports [test_sharedarraybuffer] from the Node.js test suite to the CTS.